Add sensors for Sonoff SWV Smart Water Valve status#189
Add sensors for Sonoff SWV Smart Water Valve status#189benbancroft wants to merge 2 commits intozigpy:devfrom
Conversation
|
If you run script/setup from the root of the checked out project it will set up a venv for you and also install a commit hook w/ pre-commit so that you can catch the lint errors before committing. if you already have a venv activate it and run |
|
Pre-commit fixes are now also applied automatically as well when pushed to a PR. So, you can just update your local changes from the branch you pushed to. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #189 +/- ##
==========================================
- Coverage 96.49% 96.46% -0.04%
==========================================
Files 61 61
Lines 9426 9448 +22
==========================================
+ Hits 9096 9114 +18
- Misses 330 334 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
FYI, we merged an initial quirk that defines the custom cluster and attributes: zigpy/zha-device-handlers#3346 |
|
With these PRs, we should be able to do this entirely in quirks v2 (after they're merged):
Drafting this PR for now. There's also been initial quirks v2 support added for this device via zigpy/zha-device-handlers#3346. |
|
Closing as no longer required (now implemented as v2 quirk) |
Proposed change
Adds a valve leak and water supply status binary sensors for export to Home Assistant.
This feature was requested as part of zigpy/zha-device-handlers#3298
Additional information
Testing
I have tested this with my Sonoff SWV-BSP Smart Water Valve.